From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932527AbcERRBN (ORCPT ); Wed, 18 May 2016 13:01:13 -0400 Received: from mail.kernel.org ([198.145.29.136]:49738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbcERRBM (ORCPT ); Wed, 18 May 2016 13:01:12 -0400 Date: Wed, 18 May 2016 12:01:05 -0500 From: Rob Herring To: Jan Viktorin Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Hans J. Koch" , Greg Kroah-Hartman Subject: Re: [PATCH 3/4] uio: introduce devicetree bindings for uio_dmem_genirq Message-ID: <20160518170105.GA4897@rob-hp-laptop> References: <1463476940-26791-1-git-send-email-viktorin@rehivetech.com> <1463476940-26791-4-git-send-email-viktorin@rehivetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463476940-26791-4-git-send-email-viktorin@rehivetech.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2016 at 11:22:19AM +0200, Jan Viktorin wrote: > Signed-off-by: Jan Viktorin > --- > .../devicetree/bindings/uio/uio_dmem_genirq.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/uio/uio_dmem_genirq.txt DT describes h/w. UIO is not a h/w block, so this does not belong in DT. A UIO vs. kernel driver is purely a kernel decision which shouldn't require a DT change. The properties should be part of match data for a compatible string that needs them set. Or if they can be defined in a way that is actually a property of the h/w, then it would be acceptible. You'd still need to define compatible strings that the properties apply to. Rob