From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932731AbcERR0l (ORCPT ); Wed, 18 May 2016 13:26:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37720 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbcERR0j (ORCPT ); Wed, 18 May 2016 13:26:39 -0400 Date: Wed, 18 May 2016 10:26:37 -0700 From: Greg KH To: Jes Sorensen Cc: David Kershner , corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, erik.arfvidson@unisys.com, timothy.sell@unisys.com, hofrat@osadl.org, dzickus@redhat.com, alexander.curtin@unisys.com, janani.rvchndrn@gmail.com, sudipm.mukherjee@gmail.com, prarit@redhat.com, david.binder@unisys.com, nhorman@redhat.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com Subject: Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Message-ID: <20160518172637.GB6879@kroah.com> References: <1463470081-24223-1-git-send-email-david.kershner@unisys.com> <20160517135133.GC18227@kroah.com> <20160517142735.GA19617@kroah.com> <20160518000359.GA325@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2016 at 12:03:58PM -0400, Jes Sorensen wrote: > Greg KH writes: > > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: > >> > Ok, but still no need to put it under arch/ anything, it should go in > >> > drivers/ like all other drivers and busses are, no matter what the arch > >> > it happens to run on is. > >> > >> I don't think thats obvious. arch/x86/kvm is an example of this, Sparc > >> and PPC also have their stuff under arch/. > > > > For some things, yes, but let's not make the same mistakes as others :) > > > > Look at drivers/hv/ for an example of a very x86-only bus and driver > > subsystem living in drivers/ Please don't burry driver stuff in arch/ > > the ARM developers are trying to fix their mistakes of the past and move > > all of their cruft out of arch/ for that reason. > > Works for me. > > So should they put it in drivers/visorbus or drivers/bus/visorbus? drivers/visorbus please. drivers/bus/ is an "odd" thing :( > What about drivers/virt? Would you suggest hv and xen gets moved in > there? Ah, yeah, that would be great, never noticed it before, despite being there since 2011... thanks, greg k-h