From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337AbcESKZy (ORCPT ); Thu, 19 May 2016 06:25:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:33626 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932261AbcESKZw (ORCPT ); Thu, 19 May 2016 06:25:52 -0400 Date: Thu, 19 May 2016 12:25:49 +0200 From: Jan Kara To: Alden Tondettar Cc: Jan Kara , Laura Abbott , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] udf: Use IS_ERR when loading metadata mirror file entry Message-ID: <20160519102549.GB8839@quack2.suse.cz> References: <1463605759-7616-1-git-send-email-alden.tondettar@gmail.com> <1463605759-7616-4-git-send-email-alden.tondettar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463605759-7616-4-git-send-email-alden.tondettar@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 18-05-16 14:09:18, Alden Tondettar wrote: > Currently when udf_get_pblock_meta25() fails to map a block using the > primary metadata file, it will attempt to load the mirror file entry by > calling udf_find_metadata_inode_efe(). That function will return a ERR_PTR > if it fails, but the return value is only checked against NULL. Test the > return value using IS_ERR() and change it to NULL if needed. > > Signed-off-by: Alden Tondettar Thanks. I have added this patch to my tree. Honza > --- > fs/udf/partition.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/udf/partition.c b/fs/udf/partition.c > index e4e9e70..ca3cde3 100644 > --- a/fs/udf/partition.c > +++ b/fs/udf/partition.c > @@ -326,6 +326,8 @@ uint32_t udf_get_pblock_meta25(struct super_block *sb, uint32_t block, > if (!(mdata->s_flags & MF_MIRROR_FE_LOADED)) { > mdata->s_mirror_fe = udf_find_metadata_inode_efe(sb, > mdata->s_mirror_file_loc, map->s_partition_num); > + if (IS_ERR(mdata->s_mirror_fe)) > + mdata->s_mirror_fe = NULL; > mdata->s_flags |= MF_MIRROR_FE_LOADED; > } > > -- > 2.1.4 > > -- Jan Kara SUSE Labs, CR