From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754831AbcESMPs (ORCPT ); Thu, 19 May 2016 08:15:48 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:45282 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753590AbcESMPq (ORCPT ); Thu, 19 May 2016 08:15:46 -0400 Date: Thu, 19 May 2016 14:15:43 +0200 From: Andrew Lunn To: Alexander Stein Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, john@phrozen.org Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Message-ID: <20160519121543.GB16009@lunn.ch> References: <1463587403-26809-1-git-send-email-alexander.stein@systec-electronic.com> <573C9738.4040402@gmail.com> <20160518170109.GE25448@lunn.ch> <10239730.unHAU2I5Xo@ws-stein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10239730.unHAU2I5Xo@ws-stein> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > To be honest I don't know how the PHY LEDs could be set by LED triggers. > Wouldn't that require to create triggers for each value which can be written > to LEDxH and LEDxL? In my case the hardware requires some specific setting due > to LED connections. Supporting all possibilities is not possible. However you could picking out a subset which other PHYs could also implement. Think about the typical patterns you see if you have two LEDs, which seems to be the most common setup. We would have generic PHY trigger code, and a driver specific part which configures the PHY to that configuration, if the trigger is activated. Andrew