From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754504AbcESQTa (ORCPT ); Thu, 19 May 2016 12:19:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51239 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbcESQT3 (ORCPT ); Thu, 19 May 2016 12:19:29 -0400 Date: Thu, 19 May 2016 18:19:23 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: He Kuang , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/6] perf tools: Promote proper messages for cross-platform unwind Message-ID: <20160519161923.GB18909@krava> References: <1463658462-85131-1-git-send-email-hekuang@huawei.com> <1463658462-85131-3-git-send-email-hekuang@huawei.com> <20160519145010.GA22286@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160519145010.GA22286@kernel.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 19 May 2016 16:19:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2016 at 11:50:10AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, May 19, 2016 at 11:47:38AM +0000, He Kuang escreveu: > > Currently, perf script uses host unwind methods to parse perf.data > > callchain info regardless of the target architecture. So we get wrong > > result and no promotion when unwinding callchains of x86(32-bit) on > > What you mean by "promotion" here? Can you use some other synonym so > that I can make sense of this description? I'd say something like: s/and no promotion/without any warning/ jirka