From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755403AbcESXE0 (ORCPT ); Thu, 19 May 2016 19:04:26 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35488 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753809AbcESXEY (ORCPT ); Thu, 19 May 2016 19:04:24 -0400 From: Steve Muckle X-Google-Original-From: Steve Muckle Date: Thu, 19 May 2016 16:04:19 -0700 To: "Rafael J. Wysocki" Cc: Steve Muckle , Peter Zijlstra , Ingo Molnar , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette , Viresh Kumar , Srinivas Pandruvada , Len Brown Subject: Re: [PATCH 3/5] sched: cpufreq: call cpufreq hook from remote CPUs Message-ID: <20160519230419.GB15383@graphite.smuckle.net> References: <1462828814-32530-1-git-send-email-smuckle@linaro.org> <1462828814-32530-4-git-send-email-smuckle@linaro.org> <20160519191916.GE17223@graphite.smuckle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2016 at 11:06:14PM +0200, Rafael J. Wysocki wrote: > > In the case of a remote update the hook has to run (or not) after it is > > known whether preemption will occur so we don't do needless work or > > IPIs. If the policy CPUs aren't known in the scheduler then the early > > hook will always need to be called along with an indication that it is > > the early hook being called. If it turns out to be a remote update it > > could then be deferred to the later hook, which would only be called > > when a remote update has been deferred and preemption has not occurred. > > > > This means two hook inovcations for a remote non-preempting wakeup > > though instead of one. Perhaps this is a good middle ground on code > > churn vs. optimization though. > > I would think so. Ok, I will pursue this approach. thanks, Steve