From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbcETSYX (ORCPT ); Fri, 20 May 2016 14:24:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:51732 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbcETSYW (ORCPT ); Fri, 20 May 2016 14:24:22 -0400 Date: Fri, 20 May 2016 11:24:21 -0700 (PDT) Message-Id: <20160520.112421.2148726893293404256.davem@davemloft.net> To: arnd@arndb.de Cc: jiri@mellanox.com, john.r.fastabend@intel.com, amirva@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlx5: avoid unused variable warning From: David Miller In-Reply-To: <1463581293-1069553-1-git-send-email-arnd@arndb.de> References: <1463581293-1069553-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 May 2016 11:24:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 18 May 2016 16:21:07 +0200 > When CONFIG_NET_CLS_ACT is disabled, we get a new warning in the mlx5 > ethernet driver because the tc_for_each_action() loop never references > the iterator: > > mellanox/mlx5/core/en_tc.c: In function 'mlx5e_stats_flower': > mellanox/mlx5/core/en_tc.c:431:20: error: unused variable 'a' [-Werror=unused-variable] > struct tc_action *a; > > This changes the dummy tc_for_each_action() macro by adding a > cast to void, letting the compiler know that the variable is > intentionally declared but not used here. I could not come up > with a nicer workaround, but this seems to do the trick. > > Signed-off-by: Arnd Bergmann > Fixes: aad7e08d39bd ("net/mlx5e: Hardware offloaded flower filter statistics support") > Fixes: 00175aec941e ("net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef") Applied, thanks Arnd.