From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755477AbcETAlD (ORCPT ); Thu, 19 May 2016 20:41:03 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33062 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbcETAlA (ORCPT ); Thu, 19 May 2016 20:41:00 -0400 From: Steve Muckle X-Google-Original-From: Steve Muckle Date: Thu, 19 May 2016 17:40:56 -0700 To: "Rafael J. Wysocki" Cc: Steve Muckle , Peter Zijlstra , Ingo Molnar , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette , Viresh Kumar , Srinivas Pandruvada , Len Brown Subject: Re: [PATCH 5/5] cpufreq: schedutil: do not update rate limit ts when freq is unchanged Message-ID: <20160520004056.GE15383@graphite.smuckle.net> References: <1462828814-32530-1-git-send-email-smuckle@linaro.org> <1462828814-32530-6-git-send-email-smuckle@linaro.org> <20160519194635.GG17223@graphite.smuckle.net> <20160519233408.GC15383@graphite.smuckle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 20, 2016 at 02:37:17AM +0200, Rafael J. Wysocki wrote: > Also I think that it would be good to avoid walking the frequency > table twice in case we end up wanting to update the frequency after > all. With the [4/5] we'd do it once in get_next_freq() and then once > more in cpufreq_driver_fast_switch(), for example, and walking the > frequency table may be more expensive that doing the switch in the > first place. If a driver API is added to return the platform frequency associated with a target frequency, what do you think about requiring the fast_switch API to take a target-supported frequency?