From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755654AbcETHx4 (ORCPT ); Fri, 20 May 2016 03:53:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49782 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755615AbcETHxy (ORCPT ); Fri, 20 May 2016 03:53:54 -0400 Date: Fri, 20 May 2016 09:53:48 +0200 From: Benjamin Tissoires To: Bastien Nocera Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Lejun Zhu , Fabio Estevam Subject: Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3 Message-ID: <20160520075348.GI23234@mail.corp.redhat.com> References: <1463155554-11747-1-git-send-email-benjamin.tissoires@redhat.com> <1463507131.3440.7.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1463507131.3440.7.camel@hadess.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 20 May 2016 07:53:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 17 2016 or thereabouts, Bastien Nocera wrote: > On Fri, 2016-05-13 at 18:05 +0200, Benjamin Tissoires wrote: > > Hi, > > > > This is the v2 of the series with 3 extra patches to add support of > > the buttons > > found on the Surface 3. > > > > Cheers, > > Benjamin > > > > > > Benjamin Tissoires (6): > >   Input - soc_button_array: use gpio_is_valid() > >   Input - soc_button_array: bail out earlier if gpiod_count is null > >   Input - soc_button_array: make sure one GPIO is not assigned twice > >   Input - soc_button_array: allow to specify active_low > >   Input - soc_button_array: export part of the internals > >   Input - surface3_button_array: Introduce button support for the > >     Surface 3 > > Works on my Surface 3, the volume buttons, and the Windows button work > as expected. Note that the power button does not send out any events on > my machine, but that might be due to firmware differences. > > My BIOS is listed as version 1.51116.78 released 03/09/2015. > > As there's no errors generated, it would be fine to look at it as a bug > fix later on (or for me to updated my system). > > Tested-by: Bastien Nocera Bastien told me in a different thread that the power button is not working only after a reboot from Windows. After a cold start, it works fine. There might be something that needs to be set at the I2C level, but I think while we don't know much about the I2C protocol there, it should be safe to still get this upstream. Cheers, Benjamin