From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755658AbcETNQx (ORCPT ); Fri, 20 May 2016 09:16:53 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34904 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752892AbcETNQw (ORCPT ); Fri, 20 May 2016 09:16:52 -0400 Date: Fri, 20 May 2016 15:16:49 +0200 From: Michal Hocko To: Yang Shi Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org Subject: Re: [v2 PATCH] mm: move page_ext_init after all struct pages are initialized Message-ID: <20160520131649.GC5197@dhcp22.suse.cz> References: <1463696006-31360-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463696006-31360-1-git-send-email-yang.shi@linaro.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 19-05-16 15:13:26, Yang Shi wrote: [...] > diff --git a/init/main.c b/init/main.c > index b3c6e36..2075faf 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -606,7 +606,6 @@ asmlinkage __visible void __init start_kernel(void) > initrd_start = 0; > } > #endif > - page_ext_init(); > debug_objects_mem_init(); > kmemleak_init(); > setup_per_cpu_pageset(); > @@ -1004,6 +1003,8 @@ static noinline void __init kernel_init_freeable(void) > sched_init_smp(); > > page_alloc_init_late(); > + /* Initialize page ext after all struct pages are initializaed */ > + page_ext_init(); > > do_basic_setup(); I might be missing something but don't we have the same problem with CONFIG_FLATMEM? page_ext_init_flatmem is called way earlier. Or CONFIG_DEFERRED_STRUCT_PAGE_INIT is never enabled for CONFIG_FLATMEM? -- Michal Hocko SUSE Labs