From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755355AbcEWM2j (ORCPT ); Mon, 23 May 2016 08:28:39 -0400 Received: from merlin.infradead.org ([205.233.59.134]:41839 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbcEWM2i (ORCPT ); Mon, 23 May 2016 08:28:38 -0400 Date: Mon, 23 May 2016 14:28:21 +0200 From: Peter Zijlstra To: Mike Galbraith Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, Pavan Kondeti , Ben Segall , Matt Fleming , Morten Rasmussen , Paul Turner , Thomas Gleixner , byungchul.park@lge.com, Andrew Hunter Subject: Re: [patch] sched/fair: Move se->vruntime normalization state into struct sched_entity Message-ID: <20160523122821.GI15728@worktop.ger.corp.intel.com> References: <20160510174314.355953085@infradead.org> <20160510174613.902178264@infradead.org> <1463839488.24578.45.camel@suse.de> <1463857236.10353.5.camel@gmail.com> <1463900401.30072.6.camel@gmail.com> <20160523091907.GD15728@worktop.ger.corp.intel.com> <1463996435.4537.97.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463996435.4537.97.camel@gmail.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 11:40:35AM +0200, Mike Galbraith wrote: > Yup, bugs--. Kinda funny, I considered ~this way first, but thought > you'd not that approach.. dang, got it back-assward ;-) Hehe, so the new flag is in a word we've already written to on this path and it avoids growing the structure (by an undefined number of bytes, see gripes about sizeof(bool)). I am thinking of doing the thing you did for a debug aid -- then again; if the Google guys would finally get the global vruntime patches sorted, we can go and kill all this code.