From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
gustavo@padovan.org, chris@chris-wilson.co.uk
Subject: Re: [PATCH 3/3] dma-buf/fence: add signal_on_any to the fence array
Date: Mon, 23 May 2016 16:05:22 +0200 [thread overview]
Message-ID: <20160523140522.GD27098@phenom.ffwll.local> (raw)
In-Reply-To: <57430C91.9060106@vodafone.de>
On Mon, May 23, 2016 at 03:58:41PM +0200, Christian König wrote:
> Am 23.05.2016 um 15:50 schrieb Daniel Vetter:
> >On Mon, May 23, 2016 at 01:25:22PM +0200, Christian König wrote:
> >>From: Christian König <christian.koenig@amd.com>
> >>
> >>If @signal_on_any is true the fence array signals if any fence in the array
> >>signals, otherwise it signals when all fences in the array signal.
> >What do you need this for? Sounds neat, but I can't come up with a use
> >case. And that use case imo should be both in the commit message and
> >kerneldoc.
>
> Good point, going to fix this when if we really use the patch. Just wanted
> to get opinions on this.
For getting opinions on this I get a bit the impression we're slightly
talking past each another. Having the actual user of these functions handy
should help a lot for this discussion.
> I'm currently working on making some of the resource management in amdgpu
> more friendly to our GPU scheduler.
>
> Waiting for resources in the GPU scheduler is implemented as waiting for a
> fence to fire. So when you want to wait for any resource to become available
> (like in our case the VMIDs) you could make good use of something like this.
Hm, ok, if you want a fence that fires when any resource becomes available
of a given type becomes available that might be useful. But how do you
handle the next work item that needs such a resource? Add _all_ previous
fences that use it (there's not much ordering with the scheduler) and let
them race, and retry if they fail?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-05-23 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 11:25 [PATCH 1/3] dma-buf/fence: make fence context 64 bit v2 Christian König
2016-05-23 11:25 ` [PATCH 2/3] dma-buf/fence: add fence_array fences v5 Christian König
2016-05-23 13:53 ` Daniel Vetter
2016-05-23 11:25 ` [PATCH 3/3] dma-buf/fence: add signal_on_any to the fence array Christian König
2016-05-23 11:49 ` Chris Wilson
2016-05-23 13:50 ` Daniel Vetter
2016-05-23 13:58 ` Christian König
2016-05-23 14:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523140522.GD27098@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®