From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754335AbcEWPNG (ORCPT ); Mon, 23 May 2016 11:13:06 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51498 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbcEWPNE (ORCPT ); Mon, 23 May 2016 11:13:04 -0400 Date: Mon, 23 May 2016 15:12:55 +0000 From: Serge Hallyn To: Nikolay Borisov Cc: ebiederman@xmission.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] userns: Allow init_user_ns to be used from non-gpl modules Message-ID: <20160523151255.GB1944@ubuntumail> References: <1464004808-21214-1-git-send-email-n.borisov.lkml@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464004808-21214-1-git-send-email-n.borisov.lkml@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Nikolay Borisov (n.borisov.lkml@gmail.com): > This patch changes the export attributes of the init_user_ns from > GPL-only to any modules. This needed so that non-gpl modules, such as > ZFS, utilize functions like i_(uid|gid)_(read|write). > > Signed-off-by: Nikolay Borisov Seems reasonable to me, Acked-by: Serge E. Hallyn but it seems clear the decision belongs to Eric. thanks, -serge > --- > kernel/user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/user.c b/kernel/user.c > index b069ccbfb0b0..8bbd4e628b6e 100644 > --- a/kernel/user.c > +++ b/kernel/user.c > @@ -60,7 +60,7 @@ struct user_namespace init_user_ns = { > __RWSEM_INITIALIZER(init_user_ns.persistent_keyring_register_sem), > #endif > }; > -EXPORT_SYMBOL_GPL(init_user_ns); > +EXPORT_SYMBOL(init_user_ns); > > /* > * UID task count cache, to get fast user lookup in "alloc_uid" > -- > 2.7.4 >