From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbcEWUZt (ORCPT ); Mon, 23 May 2016 16:25:49 -0400 Received: from smtprelay0077.hostedemail.com ([216.40.44.77]:55857 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752799AbcEWUZs (ORCPT ); Mon, 23 May 2016 16:25:48 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2731:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:6261:7514:7875:7903:9010:9012:9040:10004:10400:10848:10967:11232:11658:11914:12043:12296:12517:12519:12555:12740:13069:13071:13161:13229:13311:13357:13439:14180:14181:14659:14721:21060:21080:21326:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: space61_155073151fe54 X-Filterd-Recvd-Size: 2507 Date: Mon, 23 May 2016 16:25:44 -0400 From: Steven Rostedt To: Brian Norris Cc: , , Jonathan Corbet , Li Zefan Subject: Re: [PATCH] doc: clarify that trace_events= takes a comma-separated list Message-ID: <20160523162544.47d31291@gandalf.local.home> In-Reply-To: <1464034111-25340-1-git-send-email-computersforpeace@gmail.com> References: <1464034111-25340-1-git-send-email-computersforpeace@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 May 2016 13:08:31 -0700 Brian Norris wrote: Hi Brian, > It took me browsing through the source code to determine that I was, > indeed, using the wrong delimiter in my command lines. So I might as > well document it for the next person. > > Signed-off-by: Brian Norris > --- > Documentation/kernel-parameters.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index 5349363b603c..594bf50b8f81 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -3994,7 +3994,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > > trace_event=[event-list] > [FTRACE] Set and start specified trace events in order > - to facilitate early boot debugging. > + to facilitate early boot debugging. The event-list is a > + comma separated list of trace events to enable, as if > + you were to append the event(s) to > + > + /sys/kernel/debug/tracing/set_event > + I agree that we should document that the list is comma separated, but the wording you have above, makes it sound like the set_event file also takes a comma separated list, which it does not. That file requires a space separated list. Can you reword that so that it removes the confusion. Thanks! -- Steve > See also Documentation/trace/events.txt > > trace_options=[option-list]