From: Steven Rostedt <rostedt@goodmis.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH v2] doc: clarify that trace_events= takes a comma-separated list
Date: Mon, 23 May 2016 16:54:51 -0400 [thread overview]
Message-ID: <20160523165451.0069d2b0@gandalf.local.home> (raw)
In-Reply-To: <1464035878-29685-1-git-send-email-computersforpeace@gmail.com>
On Mon, 23 May 2016 13:37:58 -0700
Brian Norris <computersforpeace@gmail.com> wrote:
> It took me browsing through the source code to determine that I was,
> indeed, using the wrong delimiter in my command lines. So I might as
> well document it for the next person.
>
This version looks good to me. Jonathan, you want to take this patch?
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> v2: remove language about /sys/kernel/debug/tracing/set_event, to avoid
> implying it also takes a comma separated list
>
> Documentation/kernel-parameters.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 82b42c958d1c..a2a662d4da83 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -3992,8 +3992,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>
> trace_event=[event-list]
> [FTRACE] Set and start specified trace events in order
> - to facilitate early boot debugging.
> - See also Documentation/trace/events.txt
> + to facilitate early boot debugging. The event-list is a
> + comma separated list of trace events to enable. See
> + also Documentation/trace/events.txt
>
> trace_options=[option-list]
> [FTRACE] Enable or disable tracer options at boot.
next prev parent reply other threads:[~2016-05-23 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 20:08 [PATCH] " Brian Norris
2016-05-23 20:25 ` Steven Rostedt
2016-05-23 20:32 ` Brian Norris
2016-05-23 20:37 ` [PATCH v2] " Brian Norris
2016-05-23 20:54 ` Steven Rostedt [this message]
2016-05-23 20:56 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523165451.0069d2b0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=computersforpeace@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®