From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753612AbcEXBuy (ORCPT ); Mon, 23 May 2016 21:50:54 -0400 Received: from smtprelay0117.hostedemail.com ([216.40.44.117]:39417 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752022AbcEXBuw (ORCPT ); Mon, 23 May 2016 21:50:52 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3874:4605:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:13439:14180:14181:14659:14721:21060:21080:21088:21324:21434:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: jam96_5e187fc730c33 X-Filterd-Recvd-Size: 2202 Date: Mon, 23 May 2016 21:50:45 -0400 From: Steven Rostedt To: Namhyung Kim Cc: LKML , Masami Hiramatsu , Shuah Khan , Subject: Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests Message-ID: <20160523215045.583d0fc1@gandalf.local.home> In-Reply-To: <20160523235438.GA1636@sejong> References: <20160523151538.4ea9ce0c@gandalf.local.home> <20160523235438.GA1636@sejong> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 May 2016 08:54:38 +0900 Namhyung Kim wrote: > Hi Steve, > > On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > > > [ Folks, is this a proper work around? ] > > > > When histograms are not configured in the kernel, the ftracetest histogram > > selftests should return "unsupported" and not "Failed". To detect this, the > > test scripts have: > > > > FEATURE=`grep hist events/sched/sched_process_fork/trigger` > > if [ -z "$FEATURE" ]; then > > echo "hist trigger is not supported" > > exit_unsupported > > fi > > > > The problem is that '-e' is in effect and any error will cause the program > > to terminate. The grep for 'hist' fails, because it is not compiled it (thus > > unsupported), but because grep has an error code for failing to find the > > string, it causes the program to terminate, and is marked as a failed test. > > We have a feature check before doing grep, doesn't it detect such > case? > > if [ ! -f events/sched/sched_process_fork/trigger ]; then > echo "event trigger is not supported" > exit_unsupported > fi > Triggers exist, but the "hist" trigger does not, and that's what is being checked. -- Steve