From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932375AbcEXJKF (ORCPT ); Tue, 24 May 2016 05:10:05 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38389 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932330AbcEXJJ7 (ORCPT ); Tue, 24 May 2016 05:09:59 -0400 Date: Tue, 24 May 2016 02:09:38 -0700 From: Christoph Hellwig To: Krzysztof Kozlowski Cc: Russell King , Stefano Stabellini , Catalin Marinas , Will Deacon , Joerg Roedel , Konrad Rzeszutek Wilk , Andrew Morton , Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 0/4] dma-mapping: Constify dma_attrs Message-ID: <20160524090938.GA13166@infradead.org> References: <1464071290-15948-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464071290-15948-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think this is moving into the wrong direction. The right fix here is to get of all the dma_attrs boilerplate code and just replace it with a simple enum dma_flags. This would simplify both the callers and most importantly the wrappers for the flag-less versions a lot.