From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755685AbcEXLba (ORCPT ); Tue, 24 May 2016 07:31:30 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34195 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbcEXLb3 (ORCPT ); Tue, 24 May 2016 07:31:29 -0400 Date: Tue, 24 May 2016 13:31:25 +0200 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: fix possible css ref leak on oom Message-ID: <20160524113124.GF8259@dhcp22.suse.cz> References: <1464019330-7579-1-git-send-email-vdavydov@virtuozzo.com> <20160523174441.GA32715@dhcp22.suse.cz> <20160524084319.GH7917@esperanza> <20160524084737.GC8259@dhcp22.suse.cz> <20160524090142.GI7917@esperanza> <20160524092202.GD8259@dhcp22.suse.cz> <20160524100523.GJ7917@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160524100523.GJ7917@esperanza> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 24-05-16 13:05:23, Vladimir Davydov wrote: > On Tue, May 24, 2016 at 11:22:02AM +0200, Michal Hocko wrote: [...] > > you think about the following? I will cook up a full patch if this > > (untested) looks ok. > > It won't work for most filesystems as they define custom ->readpages. I > wonder if it'd be OK to patch them all not to trigger oom. readpages is mostly a wrapper for mpage_readpages so I guess this wouldn't be a big deal. -- Michal Hocko SUSE Labs