From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbcEYUzY (ORCPT ); Wed, 25 May 2016 16:55:24 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36509 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbcEYUzX (ORCPT ); Wed, 25 May 2016 16:55:23 -0400 Date: Wed, 25 May 2016 16:40:50 -0400 From: Tejun Heo To: "Maciej W. Rozycki" Cc: Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] workqueue: Fix an object aliasing bug with `work_data_bits' Message-ID: <20160525204050.GK3354@mtj.duckdns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2016 at 12:04:33PM +0100, Maciej W. Rozycki wrote: > Fix an aliasing issue causing a MIPS port build error: > > In file included from include/linux/srcu.h:34:0, > from include/linux/notifier.h:15, > from ./arch/mips/include/asm/uprobes.h:9, > from include/linux/uprobes.h:61, > from include/linux/mm_types.h:13, > from ./arch/mips/include/asm/vdso.h:14, > from arch/mips/vdso/vdso.h:27, > from arch/mips/vdso/gettimeofday.c:11: > include/linux/workqueue.h: In function 'work_static': > include/linux/workqueue.h:186:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] > return *work_data_bits(work) & WORK_STRUCT_STATIC; > ^ Umm... the kernel is built explicitly with -fno-strict-aliasing and it's not something individual archs can opt out. Thanks. -- tejun