From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbcEYVEG (ORCPT ); Wed, 25 May 2016 17:04:06 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:47071 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbcEYVEE (ORCPT ); Wed, 25 May 2016 17:04:04 -0400 Date: Wed, 25 May 2016 14:04:03 -0700 From: Darren Hart To: Andy Shevchenko Cc: Rajneesh Bhardwaj , platform-driver-x86@vger.kernel.org, Andy Shevchenko , "linux-kernel@vger.kernel.org" , Olof Johansson , Thomas Gleixner , "H. Peter Anvin" , dbasehore@google.com, vishwanath.somayaji@intel.com Subject: Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC Message-ID: <20160525210403.GD109010@f23x64.localdomain> References: <1464198292-32356-1-git-send-email-rajneesh.bhardwaj@intel.com> <20160525201353.GA109010@f23x64.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 11:37:21PM +0300, Andy Shevchenko wrote: > On Wed, May 25, 2016 at 11:13 PM, Darren Hart wrote: > > On Wed, May 25, 2016 at 11:14:52PM +0530, Rajneesh Bhardwaj wrote: > > > Hi Rajneesh, > > > > Unfortunately during my build test, this introduced a new warning to the build: > > > > drivers/platform/x86/intel_pmc_core.c:201:19: warning: ‘intel_pmc_core_init’ > > defined but not used [-Wunused-function] > > static int __init intel_pmc_core_init(void) > > > > After the removal of the module stuff, the driver needed a device_initcall, or > > the macro equivalent, consider: > > > > $ git diff > > diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c > > index c834281..f6a29b9 100644 > > --- a/drivers/platform/x86/intel_pmc_core.c > > +++ b/drivers/platform/x86/intel_pmc_core.c > > @@ -198,7 +198,4 @@ static struct pci_driver intel_pmc_core_driver = { > > > .remove = NULL, /* not a hot-plug capable driver */ > > Since it requires an update I would suggest to remove above line completely. Indeed, thank you Andy. -- Darren Hart Intel Open Source Technology Center