From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbcEYVYR (ORCPT ); Wed, 25 May 2016 17:24:17 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51890 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcEYVYQ (ORCPT ); Wed, 25 May 2016 17:24:16 -0400 Date: Wed, 25 May 2016 14:24:15 -0700 From: Darren Hart To: Corentin Chary Cc: =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita , "platform-driver-x86@vger.kernel.org" , acpi4asus-user , LKML , linux@endlessm.com, =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita Subject: Re: [PATCH 2/5] asus-wmi: Create quirk for airplane_mode LED Message-ID: <20160525212415.GF109010@f23x64.localdomain> References: <1454951123-27470-1-git-send-email-jprvita@endlessm.com> <1454951123-27470-3-git-send-email-jprvita@endlessm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 09:13:23AM +0200, Corentin Chary wrote: > On Mon, Feb 8, 2016 at 6:05 PM, Joćo Paulo Rechi Vita wrote: > > Some Asus laptops that have an "airplane mode" indicator LED, also have > > the WMI WLAN user bit set, and the following bits in their DSDT: > > > > Scope (_SB) > > { > > (...) > > Device (ATKD) > > { > > (...) > > Method (WMNB, 3, Serialized) > > { > > (...) > > If (LEqual (IIA0, 0x00010002)) > > { > > OWGD (IIA1) > > Return (One) > > } > > } > > } > > } > > > > So when asus-wmi uses ASUS_WMI_DEVID_WLAN_LED (0x00010002) to store the > > wlan state, it drives the airplane mode indicator LED (through the call > > to OWGD) in an inverted fashion: the LED is ON when airplane mode is OFF > > (since wlan is ON), and vice-versa. > > > > This commit creates a quirk to not register a RFKill switch at all for > > these laptops, to allow the asus-wireless driver to drive the airplane > > mode LED correctly. It also adds a match to that quirk for the Asus > > X555UB. > > This is really something that should get merged, multiple users are > affected by this. I do not own any of these laptops, but would there > be a way to detect this behavior instead of having static quircks ? I believe this is all still blocked on the underlying RFKILL support. Joćo, correct me if I'm mistaken. -- Darren Hart Intel Open Source Technology Center