From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Wan Zongshun <vw@iommu.org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
"Oded Gabbay" <oded.gabbay@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
iommu@lists.linux-foundation.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Wan Zongshun" <vincent.wan@amd.com>
Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu
Date: Fri, 27 May 2016 02:12:43 +0200 [thread overview]
Message-ID: <20160527001243.GP11948@wotan.suse.de> (raw)
In-Reply-To: <571591CC.40700@iommu.org>
On Tue, Apr 19, 2016 at 10:02:52AM +0800, Wan Zongshun wrote:
>
> You have to take carefully to arrange the calling sequence for
> iommuv1, iommuv2, kfd module, and drm like the following sequence :
> v1 ->v2->kfd, drm.
>
> iommuv1 -- rootfs_initcall(fn)
> IOMMUV2 -- device_initcall(fn)
> kfd module -- late_initcall(fn)
> drm -- late_initcall(fn)
Thanks, it turns out this is not exactly enough, given as
Joerg notes:
--
AMD-KFD on the other hand needs to be loaded before the
radeon driver (but this it not enforced by symbols), because otherwise
the radeon driver will not initialize the AMD-KFD driver.
---
We have a theoretical race still possible between the kfd module
and the drm driver. I'll reply to Joerg's e-mail with more feedback.
Luis
next prev parent reply other threads:[~2016-05-27 0:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 22:12 [RFT] " Luis R. Rodriguez
2016-03-16 7:02 ` Oded Gabbay
2016-03-16 10:14 ` Joerg Roedel
2016-03-16 10:16 ` Oded Gabbay
2016-03-16 16:17 ` Luis R. Rodriguez
2016-03-16 16:39 ` Joerg Roedel
2016-03-16 16:57 ` Luis R. Rodriguez
2016-03-16 17:17 ` Joerg Roedel
2016-03-29 17:41 ` [RFT v2] " Luis R. Rodriguez
2016-04-09 0:25 ` Luis R. Rodriguez
2016-04-11 13:28 ` Christian König
2016-04-11 13:39 ` Oded Gabbay
2016-04-11 13:52 ` Christian König
2016-04-12 22:07 ` Luis R. Rodriguez
2016-04-18 6:48 ` Oded Gabbay
[not found] ` <CAB=NE6WL7j_azrFxQUG3bybXtu67ew51CyzYvkBct6tCdARKDg@mail.gmail.com>
2016-04-18 7:02 ` Oded Gabbay
2016-04-18 12:03 ` Luis R. Rodriguez
2016-04-19 2:02 ` Wan Zongshun
2016-05-27 0:12 ` Luis R. Rodriguez [this message]
2016-04-25 10:23 ` Joerg Roedel
2016-05-27 0:46 ` Luis R. Rodriguez
2016-05-27 1:18 ` [RFT v3] drm: use late_initcall() for amdkfd and radeon Luis R. Rodriguez
2016-05-29 14:49 ` Oded Gabbay
2016-05-31 17:15 ` Luis R. Rodriguez
2016-05-31 17:33 ` Oded Gabbay
2016-05-29 18:27 ` Daniel Vetter
2016-05-31 16:58 ` Luis R. Rodriguez
2016-05-31 19:04 ` Daniel Vetter
2016-06-01 21:11 ` Luis R. Rodriguez
2016-11-10 22:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527001243.GP11948@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=christian.koenig@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
--cc=vincent.wan@amd.com \
--cc=vw@iommu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®