From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbcE3Ffp (ORCPT ); Mon, 30 May 2016 01:35:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:49634 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbcE3Ffn (ORCPT ); Mon, 30 May 2016 01:35:43 -0400 Date: Sun, 29 May 2016 22:35:42 -0700 (PDT) Message-Id: <20160529.223542.1386340561946869732.davem@davemloft.net> To: eladkan@mellanox.com Cc: noamca@mellanox.com, linux-kernel@vger.kernel.org, abrodkin@synopsys.com, netdev@vger.kernel.org Subject: Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule From: David Miller In-Reply-To: <1464264006-26627-1-git-send-email-eladkan@mellanox.com> References: <1464264006-26627-1-git-send-email-eladkan@mellanox.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 29 May 2016 22:35:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Elad Kanfi Date: Thu, 26 May 2016 15:00:06 +0300 > From: Elad Kanfi > > Since NAPI works by shutting down event interrupts when theres > work and turning them on when theres none, the net driver must > make sure that interrupts are disabled when it reschedules polling. > By calling napi_reschedule, the driver switches to polling mode, > therefor there should be no interrupt interference. > Any received packets will be handled in nps_enet_poll by polling the HW > indication of received packet until all packets are handled. > > Signed-off-by: Elad Kanfi > Acked-by: Noam Camus Applied.