From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161836AbcE3SXl (ORCPT ); Mon, 30 May 2016 14:23:41 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54152 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161330AbcE3SXk (ORCPT ); Mon, 30 May 2016 14:23:40 -0400 Date: Mon, 30 May 2016 11:23:35 -0700 (PDT) Message-Id: <20160530.112335.1376503927443399332.davem@davemloft.net> To: mhocko@kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, linux-arch@vger.kernel.org Subject: Re: [PATCH 12/17] sparc: get rid of superfluous __GFP_REPEAT From: David Miller In-Reply-To: <1464599699-30131-13-git-send-email-mhocko@kernel.org> References: <1464599699-30131-1-git-send-email-mhocko@kernel.org> <1464599699-30131-13-git-send-email-mhocko@kernel.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 30 May 2016 11:23:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko Date: Mon, 30 May 2016 11:14:54 +0200 > From: Michal Hocko > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > around 2.6.12 it has been ignored for low order allocations. > > {pud,pmd}_alloc_one is using __GFP_REPEAT but it always allocates from > pgtable_cache which is initialzed to PAGE_SIZE objects. This means that > this flag has never been actually useful here because it has always been > used only for PAGE_ALLOC_COSTLY requests. > > Cc: "David S. Miller" > Cc: linux-arch@vger.kernel.org > Signed-off-by: Michal Hocko Acked-by: David S. Miller