From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161172AbcE3IMI (ORCPT ); Mon, 30 May 2016 04:12:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:38895 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161098AbcE3IMH (ORCPT ); Mon, 30 May 2016 04:12:07 -0400 Date: Mon, 30 May 2016 11:11:44 +0300 From: Dan Carpenter To: Jaime Arrocha Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, charrer@alacritech.com, liodot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: slicoss: fix coding style spacing issues Message-ID: <20160530081144.GB18199@mwanda> References: <1464528666-6647-1-git-send-email-jarr@innercoder.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464528666-6647-1-git-send-email-jarr@innercoder.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 29, 2016 at 08:31:06AM -0500, Jaime Arrocha wrote: > struct slic_cmdqueue { > struct slic_hostcmd *head; > struct slic_hostcmd *tail; > - int count; > - spinlock_t lock; > + int count; > + spinlock_t lock; > }; The original code was better. Same for the rest. regards, dan carpenter