mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: tom@herbertland.com, valentinrothberg@gmail.com,
	ziegler@cs.fau.de, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fou: fix IPv6 Kconfig options
Date: Tue, 31 May 2016 14:08:04 -0700 (PDT)	[thread overview]
Message-ID: <20160531.140804.27676513823707793.davem@davemloft.net> (raw)
In-Reply-To: <1464727353-22489-1-git-send-email-arnd@arndb.de>

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 31 May 2016 22:42:11 +0200

> The Kconfig options I added to work around broken compilation ended
> up screwing up things more, as I used the wrong symbol to control
> compilation of the file, resulting in IPv6 fou support to never be built
> into the kernel.
> 
> Changing CONFIG_NET_FOU_IPV6_TUNNELS to CONFIG_IPV6_FOU fixes that
> problem, I had renamed the symbol in one location but not the other,
> and as the file is never being used by other kernel code, this did not
> lead to a build failure that I would have caught.
> 
> After that fix, another issue with the same patch becomes obvious, as we
> 'select INET6_TUNNEL', which is related to IPV6_TUNNEL, but not the same,
> and this can still cause the original build failure when IPV6_TUNNEL is
> not built-in but IPV6_FOU is. The fix is equally trivial, we just need
> to select the right symbol.
> 
> I have successfully build 350 randconfig kernels with this patch
> and verified that the driver is now being built.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
> Fixes: fabb13db448e ("fou: add Kconfig options for IPv6 support")

Applied, thanks Arnd.

      reply	other threads:[~2016-05-31 21:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 20:42 Arnd Bergmann
2016-05-31 21:08 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531.140804.27676513823707793.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arnd@arndb.de \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    --cc=valentinrothberg@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=ziegler@cs.fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®