From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756541AbcEaVLO (ORCPT ); Tue, 31 May 2016 17:11:14 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37535 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbcEaVLM (ORCPT ); Tue, 31 May 2016 17:11:12 -0400 Date: Tue, 31 May 2016 14:11:11 -0700 (PDT) Message-Id: <20160531.141111.2242150565551090751.davem@davemloft.net> To: vkuznets@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ariel.elior@qlogic.com Subject: Re: [PATCH net] bnx2x: avoid leaking memory on bnx2x_init_one() failures From: David Miller In-Reply-To: <1464613254-13640-1-git-send-email-vkuznets@redhat.com> References: <1464613254-13640-1-git-send-email-vkuznets@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 May 2016 14:11:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov Date: Mon, 30 May 2016 15:00:54 +0200 > bnx2x_init_bp() allocates memory with bnx2x_alloc_mem_bp() so if we > fail later in bnx2x_init_one() we need to free this memory > with bnx2x_free_mem_bp() to avoid leakages. E.g. I'm observing memory > leaks reported by kmemleak when a failure (unrelated) happens in > bnx2x_vfpf_acquire(). > > Signed-off-by: Vitaly Kuznetsov Applied.