From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755438AbcEaVUt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2016 17:20:49 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:37605 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750813AbcEaVUs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2016 17:20:48 -0400
Date: Tue, 31 May 2016 14:20:46 -0700 (PDT)
Message-Id: <20160531.142046.2026659803711147043.davem@davemloft.net>
To: Yuval.Mintz@qlogic.com
Cc: arnd@arndb.de, manish.chopra@qlogic.com, Sudarsana.Kalluru@qlogic.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ariel.Elior@qlogic.com
Subject: Re: [PATCH] qed: fix qed_fill_link() error handling
From: David Miller <davem@davemloft.net>
In-Reply-To: <CO2PR11MB00881A57063B9AB617359A9097450@CO2PR11MB0088.namprd11.prod.outlook.com>
References: <1464623197-2084229-1-git-send-email-arnd@arndb.de>
	<CO2PR11MB00881A57063B9AB617359A9097450@CO2PR11MB0088.namprd11.prod.outlook.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 May 2016 14:20:47 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Mon, 30 May 2016 16:24:07 +0000

>> +	if (IS_ENABLED(CONFIG_QED_SRIOV) && !IS_PF(hwfn->cdev)) {
>> +		qed_vf_get_link_params(hwfn, params);
>> +		qed_vf_get_link_state(hwfn, link);
>> +		qed_vf_get_link_caps(hwfn, link_caps);
>> +
>> +		return 0;
>> +	}
> 
> The IS_ENABLED here seems a bit wasteful to me - we have empty implementation
> under qed_vf.h just for this case [I.e., that SRIOV isn't enabled for qed].
> If all we're trying achieve is removing these gcc warnings, I think we can simply
> memset the structs in the currently-empty qed_vf_get_link_* functions.

I think both solutions are equally valid/elegant.

Arnd?