From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752860AbcEaKlc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2016 06:41:32 -0400
Received: from merlin.infradead.org ([205.233.59.134]:48611 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751961AbcEaKl2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2016 06:41:28 -0400
Date: Tue, 31 May 2016 12:41:21 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Yuyang Du <yuyang.du@intel.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, umgwanakikbuti@gmail.com,
        bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com
Subject: Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched
 domain build-up
Message-ID: <20160531104121.GJ3190@twins.programming.kicks-ass.net>
References: <1464657098-24880-1-git-send-email-yuyang.du@intel.com>
 <1464657098-24880-2-git-send-email-yuyang.du@intel.com>
 <20160531092146.GT3192@twins.programming.kicks-ass.net>
 <20160531013132.GQ18670@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160531013132.GQ18670@intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 31, 2016 at 09:31:32AM +0800, Yuyang Du wrote:
> On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote:
> > On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> > > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> > > and in addition SD_BALANCE_WAKE is not and should not be set in any
> > > sched_domain flags so far.
> > 
> > This Changelog doesn't make any sense...
> 
> How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if
> it is, it is not used anywhere, no?

It is and it is. See select_task_fair_rq():

	if (tmp->flags & sd_flags)

Now, as long as WAKE_AFFINE is also set, its hard to actually get into
the find_idlest_cpu() balancing, but if you clear all that you will
still get there.