From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755991AbcEaR3z (ORCPT ); Tue, 31 May 2016 13:29:55 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:35812 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbcEaR3u (ORCPT ); Tue, 31 May 2016 13:29:50 -0400 Date: Tue, 31 May 2016 13:29:48 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Boris Ostrovsky , David Vrabel , Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] xen: xenbus: Remove create_workqueue Message-ID: <20160531172948.GI29775@mtj.duckdns.org> References: <20160531165630.GA21779@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531165630.GA21779@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 10:26:30PM +0530, Bhaktipriya Shridhar wrote: > System workqueues have been able to handle high level of concurrency > for a long time now and there's no reason to use dedicated workqueues > just to gain concurrency. Replace dedicated xenbus_frontend_wq with the > use of system_wq. > > Unlike a dedicated per-cpu workqueue created with create_workqueue(), > system_wq allows multiple work items to overlap executions even on > the same CPU; however, a per-cpu workqueue doesn't have any CPU > locality or global ordering guarantees unless the target CPU is > explicitly specified and the increase of local concurrency shouldn't > make any difference. > > In this case, there is only a single work item, increase of concurrency > level by switching to system_wq should not make any difference. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun