From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756039AbcEaRsV (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2016 13:48:21 -0400
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:52946 "EHLO
	metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S932116AbcEaRrz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2016 13:47:55 -0400
Date: Tue, 31 May 2016 19:47:48 +0200
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
To: "George G. Davis" <george_davis@mentor.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Fugang Duan <fugang.duan@nxp.com>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        Russell King <linux@armlinux.org.uk>, Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Kumar Gala <galak@codeaurora.org>, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API
Message-ID: <20160531174748.GI26768@pengutronix.de>
References: <1464715071-56012-1-git-send-email-george_davis@mentor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1464715071-56012-1-git-send-email-george_davis@mentor.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello George,

On Tue, May 31, 2016 at 01:17:51PM -0400, George G. Davis wrote:
> Convert the i.MX FEC driver and DT files to use the GPIOD API
> which automatically handles GPIO polarity.

additionally to what Fabio said, there is also a nicer approach in the
making. The resulting dts would look as follows:

	&fec {
		phy-handle = <&ethphy>;
		...

		mdio {
			#address-cells = <1>;
			#size-cells = <0>;

			ethphy: ethernet-phy@7 {
				...

				reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
			};
		};
	};

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |