From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Baolin Wang <baolin.wang@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Shuah Khan <shuahkh@osg.samsung.com>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Prarit Bhargava <prarit@redhat.com>
Subject: Re: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking
Date: Wed, 1 Jun 2016 13:49:39 +0300 [thread overview]
Message-ID: <20160601104939.GT1743@lahna.fi.intel.com> (raw)
In-Reply-To: <1464730335-21427-2-git-send-email-john.stultz@linaro.org>
On Tue, May 31, 2016 at 02:32:14PM -0700, John Stultz wrote:
> In commit 86d3473224b0 ("time: Introduce do_sys_settimeofday64()")
> some of the checking for a valid timeval was subtley changed
> which caused -EINVAL to be returned whenever the timeval was null.
>
> However, it is possible to set the timezone data while specifying
> a NULL timeval, which is usually done to handle systems where the
> RTC keeps local time instead of UTC. Thus the patch causes such
> systems to have the time incorrectly set.
>
> This patch addresses the issue by handling the error conditionals
> in the same way as was done previously.
>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Prarit Bhargava <prarit@redhat.com>
> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
I can confirm that this patch fixes the issue I'm seeing. Thanks!
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-06-01 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:32 [RFC][PATCH 0/2] Fix for settimeofday() error checking regression John Stultz
2016-05-31 21:32 ` [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking John Stultz
2016-06-01 2:16 ` Dima Stepanov
2016-06-01 10:49 ` Mika Westerberg [this message]
2016-05-31 21:32 ` [RFC][PATCH 2/2] kselftests: timers: Add set-tz test case John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601104939.GT1743@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome