From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbcFATUd (ORCPT ); Wed, 1 Jun 2016 15:20:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39401 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbcFATUc (ORCPT ); Wed, 1 Jun 2016 15:20:32 -0400 Date: Wed, 1 Jun 2016 12:20:30 -0700 From: Andrew Morton To: Luis de Bethencourt Cc: Al Viro , linux-kernel@vger.kernel.org Subject: Re: [PATCH] befs: remove unused endian functions Message-Id: <20160601122030.73fa60cb35a8bb4a306835bb@linux-foundation.org> In-Reply-To: <574DFB17.5080904@osg.samsung.com> References: <1464701277-29962-1-git-send-email-luisbg@osg.samsung.com> <20160531205455.GE14480@ZenIV.linux.org.uk> <574DFB17.5080904@osg.samsung.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 May 2016 21:59:03 +0100 Luis de Bethencourt wrote: > On 31/05/16 21:54, Al Viro wrote: > > On Tue, May 31, 2016 at 02:27:57PM +0100, Luis de Bethencourt wrote: > >> Remove endianness conversion functions that are declared but never used. > > > > Well... As long as it stays read-only - sure, you don't need to convert > > anything to on-disk types. I think it would be best to leave the code as-is. The compiler will remove it all so there's a very small amount of compile-time cost. We could just comment the code out but then they would rot over time, > > Hello, > > While reading the BeFS book "Practical Filesystems" I have gotten really > interested in this and it's why I am reading/learning the Linux > implementation. > > The idea of adding write support has crossed my mind, but I wanted to know > if you would be interested in this before I start looking into it. Are you? > > It would take some time and there are other things to clean in the befs code > first though. It could be a fun starter project but I have to say, befs is not a very valuable place in which to spend your time nor is befs the best place in which to develop familiarity. A more modest project within a more mainstream part of the kernel would be a better investment.