From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbcFAW2U (ORCPT ); Wed, 1 Jun 2016 18:28:20 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:58482 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbcFAW2R (ORCPT ); Wed, 1 Jun 2016 18:28:17 -0400 Date: Wed, 1 Jun 2016 18:28:09 -0400 From: Rich Felker To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , Linux-sh list Subject: Re: Build regressions/improvements in v4.7-rc1 Message-ID: <20160601222809.GG10893@brightrain.aerifal.cx> References: <1464593333-10283-1-git-send-email-geert@linux-m68k.org> <20160601221801.GF10893@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160601221801.GF10893@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2016 at 06:18:02PM -0400, Rich Felker wrote: > On Mon, May 30, 2016 at 09:34:07AM +0200, Geert Uytterhoeven wrote: > > > + /home/kisskb/slave/src/arch/sh/kernel/setup.c: error: implicit declaration of function 'early_init_dt_scan' [-Werror=implicit-function-declaration]: => 256:2 > > > > sh-randconfig > > Nice find. I think I'm incorrectly checking for CONFIG_OF in places > that should actually be checking for CONFIG_OF_FLATTREE. Does that > look right to you? Nothing breaks in actual configurations that make > sense now, only if you enable OF manually without selecting > SH_DEVICE_TREE as your board. > > If you can confirm that my assessment is correct I'll include a fix in > my (now-late) pull request. BTW it seems a bigger version of the same issue affects my J2 support patch series: CONFIG_CPU_J2 enables code that performs an early FDT scan to obtain cache information, so it needs to select OF and OF_FLATTREE to avoid build errors. Eventually none of this will matter once we drop legacy support and make it so SUPERH implies OF and OF_EARLY_FLATTREE. Rich