From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753542AbcFBTPo (ORCPT ); Thu, 2 Jun 2016 15:15:44 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:58016 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbcFBTPn (ORCPT ); Thu, 2 Jun 2016 15:15:43 -0400 Date: Thu, 02 Jun 2016 12:15:41 -0700 (PDT) Message-Id: <20160602.121541.1591890175711948513.davem@davemloft.net> To: bhaktipriya96@gmail.com Cc: akinobu.mita@gmail.com, a@unstable.cc, felipe.balbi@linux.intel.com, fw@strlen.de, tj@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue From: David Miller In-Reply-To: <20160601175914.GA5169@Karyakshetra> References: <20160601175914.GA5169@Karyakshetra> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Jun 2016 12:15:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhaktipriya Shridhar Date: Wed, 1 Jun 2016 23:29:15 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitems are involved > in normal device operation. Workitems &priv->rx_work and &priv->tx_work, > map to w5100_rx_work and w5100_tx_work respectively and are involved in > receiving and transmitting packets. Forward progress under > memory pressure is a requirement here. > > create_workqueue has been replaced with alloc_workqueue with max_active > as 0 since there is no need for throttling the number of active work > items. > > Since the driver may be used in memory reclaim path, > WQ_MEM_RECLAIM has been set to guarantee forward progress. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. Hence the call to flush_workqueue() has been dropped. > > Signed-off-by: Bhaktipriya Shridhar Applied to net-next, thanks.