From: Peter Zijlstra <peterz@infradead.org>
To: dbasehore@chromium.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com,
tglx@linutronix.de
Subject: Re: [PATCH 5/5] intel_idle: Add S0ix validation
Date: Thu, 2 Jun 2016 11:25:05 +0200 [thread overview]
Message-ID: <20160602092505.GQ3206@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1464842009-21789-6-git-send-email-dbasehore@chromium.org>
On Wed, Jun 01, 2016 at 09:33:29PM -0700, dbasehore@chromium.org wrote:
> +/*
> + * Default chosen to have <= 1% power increase while allowing fast detection of
> + * SLP S0 entry errors. Waking up 10 times a second shows ~30% increase in
> + * system power on Skylake Y. Waking up once every 10 seconds is
> + * indistinguishable from not waking up at all (as ~0.3% power increase would
> + * be). Any reasonable power increases above this will not be visible to the
> + * user.
> + */
> +#define DEFAULT_SLP_S0_SECONDS 10
So I don't think anybody waits for 10 seconds to see if suspend worked.
After 10 seconds its in the bag and I'm out the door.
Then what?
Why can't you fire a single timer after 0.5 seconds to see if you hit
C10 and leave it at that? What's the point any further wakeup, if you
know you hit C10, you're good continue on.
next prev parent reply other threads:[~2016-06-02 9:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 4:33 [PATCH 0/5] Add suspend-to-idle validation for Intel SoCs dbasehore
2016-06-02 4:33 ` [PATCH 1/5] x86: stub out pmc function dbasehore
2016-06-02 4:33 ` [PATCH 2/5] clockevents: Add timed freeze dbasehore
2016-06-02 4:33 ` [PATCH 3/5] x86, apic: Add timed freeze support dbasehore
2016-06-02 4:33 ` [PATCH 4/5] freeze: Add error reporting dbasehore
2016-06-02 4:33 ` [PATCH 5/5] intel_idle: Add S0ix validation dbasehore
2016-06-02 9:25 ` Peter Zijlstra [this message]
2016-06-02 13:23 ` One Thousand Gnomes
2016-06-02 18:31 ` dbasehore .
2016-06-02 18:55 ` dbasehore .
2016-06-02 19:53 ` One Thousand Gnomes
2016-06-02 20:35 ` dbasehore .
2016-06-04 12:22 ` Alan
2016-06-06 21:39 ` dbasehore .
2016-06-07 7:46 ` [PATCH 0/5] Add suspend-to-idle validation for Intel SoCs Pavel Machek
2016-06-08 0:07 ` dbasehore .
2016-06-11 20:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602092505.GQ3206@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dbasehore@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®