From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932974AbcFBPB0 (ORCPT ); Thu, 2 Jun 2016 11:01:26 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57652 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932210AbcFBPBZ (ORCPT ); Thu, 2 Jun 2016 11:01:25 -0400 Date: Thu, 2 Jun 2016 17:01:18 +0200 From: Andrew Lunn To: Mario_Limonciello@Dell.com Cc: pali.rohar@gmail.com, hayeswang@realtek.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, anthony.wong@canonical.com Subject: Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Message-ID: <20160602150118.GB15379@lunn.ch> References: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> <20160602074656.GM29844@pali> <1fdac44606c74fc09bcb95cd0c7f5f87@ausx13mpc124.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1fdac44606c74fc09bcb95cd0c7f5f87@ausx13mpc124.AMER.DELL.COM> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > > + pr_info("r8152: Using system auxiliary MAC address"); > > > > It would be great to write also mac address into that pr_info And since there could be multiple r8152 in the system, it would be good to indicate which of them is having its MAC changed. So netdev_info() or dev_info(). Andrew