From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523AbcFBQY1 (ORCPT ); Thu, 2 Jun 2016 12:24:27 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35612 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbcFBQY0 (ORCPT ); Thu, 2 Jun 2016 12:24:26 -0400 Date: Thu, 2 Jun 2016 17:24:10 +0100 From: Mark Brown To: Bjorn Andersson Cc: Srinivas Kandagatla , linux-kernel@vger.kernel.org, Liam Girdwood , linux-arm-msm@vger.kernel.org Message-ID: <20160602162410.GO2282@sirena.org.uk> References: <1464862996-3147-1-git-send-email-srinivas.kandagatla@linaro.org> <1464862996-3147-4-git-send-email-srinivas.kandagatla@linaro.org> <20160602144932.GK2282@sirena.org.uk> <57504966.6030800@linaro.org> <20160602155032.GL2282@sirena.org.uk> <20160602160432.GF1256@tuxbot> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+gHRqQ1BTyNna/y8" Content-Disposition: inline In-Reply-To: <20160602160432.GF1256@tuxbot> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 92.54.156.156 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+gHRqQ1BTyNna/y8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 02, 2016 at 09:04:32AM -0700, Bjorn Andersson wrote: > On Thu 02 Jun 08:50 PDT 2016, Mark Brown wrote: > > It's more natural to use a separate set of ops, and we can optimise a > > few things if we know the regulator is a fixed voltage one. > In my view a fixed regulator is a thing that when you turn it on you get > a predefined voltage, but iirc we actually need to send of a set-voltage > request for the singly supported voltage on this ldo (which both > implementations do today...). > That's why I suggested Srini to do it this way, but maybe my > interpretation of "fixed" is inaccurate? If it only supports one voltage then shouldn't we just tell it that voltage once at startup? Doing a call in the probe routine would be fine, the framework doesn't need to know about that really. --+gHRqQ1BTyNna/y8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXUF1lAAoJECTWi3JdVIfQ6HkH/3t9eHaTGF4XycU11OfGMxjN FrJyJHN1YADrhmy112Hn1lHQsUGNlyj2rVn1Uqqv9GYRjOuCNWldWstYByeS7hSn a5N4jjhJxNF449Rey+pyqSIPpDN/pKKJRjetkw8WkD35rPRM7TSTtsjMohIinVyG d2ceofEzpI1Y3z2i6ZJ8Epgp1It3YZ5Dzgq32OtmpYGUVm2uN1SL/vl1tPdd3U48 RuRULDlcwjNM/YRQYN9b/HoQ3iEdQSeny50NB8OXhOHTtfIPhFjUHtLCY/hnTlyU tKF2iK7Qw4I+dLqlcB2hrsSA2wyrR8+0oL8jL0U8TDJxLNSiuvRbkxRTB7ojkMw= =UrdU -----END PGP SIGNATURE----- --+gHRqQ1BTyNna/y8--