From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbcFCGfT (ORCPT ); Fri, 3 Jun 2016 02:35:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35660 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbcFCGfS (ORCPT ); Fri, 3 Jun 2016 02:35:18 -0400 Date: Fri, 3 Jun 2016 14:35:14 +0800 From: Xiong Zhou To: David Drysdale , hch@lst.de Cc: Xiong Zhou , Stephen Rothwell , axboe@fb.com, linux-next@vger.kernel.org, linux-nvdimm@ml01.01.org, "linux-kernel@vger.kernel.org" Subject: Re: linux-next/linux memleak after IO on dax mountpoint Message-ID: <20160603063514.GA16231@dhcp12-144.nay.redhat.com> References: <20160527084617.GD2933@dhcp12-144.nay.redhat.com> <20160528040554.GA23685@dhcp12-144.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 03 Jun 2016 06:35:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 04:22:37PM +0100, David Drysdale wrote: > On Sat, May 28, 2016 at 5:05 AM, Xiong Zhou wrote: > > On Fri, May 27, 2016 at 04:46:17PM +0800, Xiong Zhou wrote: > > ... > >> Still working on to id which commit in this merge causes this issuer, > > > > Narrowed down to: > > > > 37e5823 block: add offset in blk_add_request_payload() ... > > 0bf77e9 nvme: switch to RCU freeing the namespace > > 9082e87 block: remove struct bio_batch > > FWIW, I'm also seeing kmemleak report a leak with v4.7-rc1, in > a different scenario (just normal desktop use). Not done much > digging so far, but this commit (9082e87bf) looks like it might be > relevant Thanks for the tip, accelerated my searching in the block merge. On top of v4.7-rc1 , in order to revert this commit cleanly: 9082e87 block: remove struct bio_batch , have to revert these two: bbd848e0f block: reinstate early return of -EOPNOTSUPP from blkdev_issue_discard 38f2525 block: add __blkdev_issue_discard , then have to revert these two dependances: 202bae5 dm thin: unroll issue_discard() to create longer discard bio chains 3dba53a9 dm thin: use __blkdev_issue_discard for async discard support With all these five commits reverted, NO memleak happens. Reverting other four commits while not reverting 9082e87, memleak happens. Thanks, Xiong