From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932613AbcFCMBW (ORCPT ); Fri, 3 Jun 2016 08:01:22 -0400 Received: from merlin.infradead.org ([205.233.59.134]:51761 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932150AbcFCMBS (ORCPT ); Fri, 3 Jun 2016 08:01:18 -0400 Date: Fri, 3 Jun 2016 14:00:42 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: Linus Torvalds , Jason Low , Ingo Molnar , Linux Kernel Mailing List , Andrew Morton , Richard Henderson , Ivan Kokshaysky , Matt Turner , Tony Luck , Fenghua Yu , Martin Schwidefsky , Terry Rudd , Heiko Carstens , Thomas Gleixner , Arnd Bergmann , Christoph Lameter , Davidlohr Bueso , Waiman Long , Tim Chen , Peter Hurley , Jason Low Subject: Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t Message-ID: <20160603120042.GL3190@twins.programming.kicks-ass.net> References: <1463445486-16078-1-git-send-email-jason.low2@hpe.com> <20160517110906.GW3193@twins.programming.kicks-ass.net> <20160603080407.GA12056@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160603080407.GA12056@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: > So I tried to pick up this series, and it broke the Alpha and IA64 builds: > > /home/mingo/tip/arch/ia64/include/asm/rwsem.h: In function '___down_write': > /home/mingo/tip/arch/ia64/include/asm/rwsem.h:58:7: error: incompatible types when > assigning to type 'long int' from type 'atomic_long_t' > old = sem->count; > ^ > > home/mingo/tip/arch/alpha/include/asm/rwsem.h: In function '__down_read': > /home/mingo/tip/arch/alpha/include/asm/rwsem.h:28:11: error: incompatible types > when assigning to type 'long int' from type 'atomic_long_t' > oldcount = sem->count; > ^ Yeah, that's intermediate borkage, the easiest fix would be to just fold the two patches. Let me do that and verify it builds properly. > > btw., for some reason I don't have the mails from Jason in my mbox, perhaps GMail > spam filtering ate it? Linus has been complaining about a lot of lost email due to gmail's idea of what constitutes spam, so that's entirely possible.