From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161191AbcFCMOh (ORCPT ); Fri, 3 Jun 2016 08:14:37 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:34362 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161075AbcFCMOf (ORCPT ); Fri, 3 Jun 2016 08:14:35 -0400 Date: Fri, 3 Jun 2016 07:14:32 -0500 From: Rob Herring To: Sergei Shtylyov Cc: grant.likely@linaro.org, devicetree@vger.kernel.org, frowand.list@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: irq: don't return 0 from of_irq_get() Message-ID: <20160603121432.GB8472@rob-hp-laptop> References: <20938812.efaALfQEUn@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20938812.efaALfQEUn@wasted.cogentembedded.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 29, 2016 at 12:53:08AM +0300, Sergei Shtylyov wrote: > of_irq_get() returns 0 iff irq_create_of_mapping() call fails. Returning > both error code and 0 on failure is a sign of a misdesigned API. Return > -ENXIO instead like one of the callers, platform_get_irq(), does; fix up > the kernel-doc as well... > > Signed-off-by: Sergei Shtylyov So I think this is done this way because of the variation in NO_IRQ definition across architectures. But then again, of_irq_get is relatively new. Rob