From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbcFCXJ6 (ORCPT ); Fri, 3 Jun 2016 19:09:58 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34358 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbcFCXJy (ORCPT ); Fri, 3 Jun 2016 19:09:54 -0400 Date: Sat, 4 Jun 2016 01:09:50 +0200 From: Daniel Vetter To: Stefan Agner Cc: thierry.reding@gmail.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, jianwei.wang.chn@gmail.com, meng.yi@nxp.com, alexander.stein@systec-electronic.com, linux-kernel@vger.kernel.org, alison.wang@freescale.com Subject: Re: [PATCH v2 1/6] drm/fb_cma_helper: add suspend helper Message-ID: <20160603230950.GB14529@phenom.ffwll.local> Mail-Followup-To: Stefan Agner , thierry.reding@gmail.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, jianwei.wang.chn@gmail.com, meng.yi@nxp.com, alexander.stein@systec-electronic.com, linux-kernel@vger.kernel.org, alison.wang@freescale.com References: <1464994604-4473-1-git-send-email-stefan@agner.ch> <1464994604-4473-2-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464994604-4473-2-git-send-email-stefan@agner.ch> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2016 at 03:56:39PM -0700, Stefan Agner wrote: > Implement a suspend/resume helper for CMA users which calls > drm_fb_helper_set_suspend. > > Suggested-by: Thierry Reding > Signed-off-by: Stefan Agner Acked-by: Daniel Vetter ... for merging through fsl-du tree. Just add a small note about it in your pull request. -Daniel > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 15 +++++++++++++++ > include/drm/drm_fb_cma_helper.h | 1 + > 2 files changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index 172cafe..6948d82 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -582,3 +582,18 @@ void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma) > drm_fb_helper_hotplug_event(&fbdev_cma->fb_helper); > } > EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event); > + > +/** > + * drm_fbdev_cma_set_suspend - wrapper around drm_fb_helper_set_suspend > + * @fbdev_cma: The drm_fbdev_cma struct, may be NULL > + * @state: desired state, zero to resume, non-zero to suspend > + * > + * Calls drm_fb_helper_set_suspend, which is a wrapper around > + * fb_set_suspend implemented by fbdev core. > + */ > +void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, int state) > +{ > + if (fbdev_cma) > + drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state); > +} > +EXPORT_SYMBOL(drm_fbdev_cma_set_suspend); > diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h > index fd0dde9..f313211 100644 > --- a/include/drm/drm_fb_cma_helper.h > +++ b/include/drm/drm_fb_cma_helper.h > @@ -23,6 +23,7 @@ void drm_fbdev_cma_fini(struct drm_fbdev_cma *fbdev_cma); > > void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma); > void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma); > +void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, int state); > int drm_fbdev_cma_create_with_funcs(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes, > const struct drm_framebuffer_funcs *funcs); > -- > 2.8.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch