From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbcFFDLG (ORCPT ); Sun, 5 Jun 2016 23:11:06 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37718 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbcFFDLE (ORCPT ); Sun, 5 Jun 2016 23:11:04 -0400 Date: Sun, 05 Jun 2016 23:11:02 -0400 (EDT) Message-Id: <20160605.231102.1130873370221997319.davem@davemloft.net> To: thloh@altera.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, peppe.cavallaro@st.com, dinguyen@altera.com, thloh85@gmail.com, cnphoon@altera.com, phooncn@gmail.com Subject: Re: [PATCH 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga From: David Miller In-Reply-To: <1464944835-21575-1-git-send-email-thloh@altera.com> References: <1464944835-21575-1-git-send-email-thloh@altera.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 05 Jun 2016 20:11:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Date: Fri, 3 Jun 2016 02:07:15 -0700 > From: Tien Hock Loh > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > the dwmac is set to sgmii > > Signed-off-by: Tien Hock Loh Please at least make an effort to use consistent coding style. You rework this function to do this: > - if (!splitter_base) > - return; > + if (splitter_base) { And then you add something like this: > + if ((tse_pcs_base) && (sgmii_adapter_base)) { > + tse_pcs_fix_mac_speed(&dwmac->pcs, phy_dev, speed); > + } Excessive parenthesis in the if() condition, and single statement basic blocks do not get curly braces.