From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751396AbcFEBgP (ORCPT ); Sat, 4 Jun 2016 21:36:15 -0400 Received: from know-smtprelay-omc-4.server.virginmedia.net ([80.0.253.68]:47022 "EHLO know-smtprelay-omc-4.server.virginmedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151AbcFEBgM (ORCPT ); Sat, 4 Jun 2016 21:36:12 -0400 X-Originating-IP: [81.100.29.190] X-Spam: 0 X-Authority: v=2.1 cv=a9rNjhmF c=1 sm=1 tr=0 a=+He7s6SjlwGdCRwhjLOitA==:117 a=+He7s6SjlwGdCRwhjLOitA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=pD_ry4oyNxEA:10 a=pGLkceISAAAA:8 a=KqaZkwCwcjHClhw3SigA:9 a=QEXdDO2ut3YA:10 a=6kGIvZw6iX1k4Y-7sg4_:22 Date: Sun, 5 Jun 2016 02:36:09 +0100 From: Ken Moffat To: Justin Keller Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] documentation: ntb.txt correct grammar "however" Message-ID: <20160605013609.GA25079@milliways.localdomain> References: <8CC2D7F1-5F56-411B-877F-40CD04DD1FEB@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett Content-Transfer-Encoding: 8bit In-Reply-To: <8CC2D7F1-5F56-411B-877F-40CD04DD1FEB@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote: > Correct the grammar around the word however. > > Signed-off-by: Justin Keller > > --- > > index 1d9bbab..5d43510 100644 > --- a/Documentation/ntb.txt > +++ b/Documentation/ntb.txt > @@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange > messages and data. The NTB Netdev then creates an ethernet device using a > Transport queue pair. Network data is copied between socket buffers and the > Transport queue pair buffer. The Transport client may be used for other things > -besides Netdev, however no other applications have yet been written. > +besides Netdev; however, no other applications have yet been written. > > ### NTB Ping Pong Test Client (ntb\_pingpong) As a user of British English, the original looks fine. Your change, however, looks odd - a semi-colon seems out of place. If you replaced it by a full-stop it would look acceptable to me - but not in any sense better than what is there at the moment. ĸen -- I had to walk fifteen miles to school, barefoot in the snow. Uphill both ways.