From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbcFETZd (ORCPT ); Sun, 5 Jun 2016 15:25:33 -0400 Received: from science.sciencehorizons.net ([71.41.210.147]:54203 "HELO ns.sciencehorizons.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with SMTP id S1750956AbcFETZa (ORCPT ); Sun, 5 Jun 2016 15:25:30 -0400 Date: 5 Jun 2016 15:25:27 -0400 Message-ID: <20160605192527.23210.qmail@ns.sciencehorizons.net> From: "George Spelvin" To: andriy.shevchenko@linux.intel.com, linux@sciencehorizons.net Subject: Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning Cc: bjorn@mork.no, linux-kernel@vger.kernel.org, matt@codeblueprint.co.uk, rv@rasmusvillemoes.dk In-Reply-To: <1465136464.1767.57.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>From andriy.shevchenko@linux.intel.com Sun Jun 05 14:19:48 2016 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,421,1459839600"; d="scan'208";a="995605979" Subject: Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning From: Andy Shevchenko To: George Spelvin Cc: bjorn@mork.no, linux-kernel@vger.kernel.org, matt@codeblueprint.co.uk, rv@rasmusvillemoes.dk Date: Sun, 05 Jun 2016 17:21:04 +0300 In-Reply-To: <20160604131622.28377.qmail@ns.sciencehorizons.net> References: <20160604131622.28377.qmail@ns.sciencehorizons.net> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Andy Shevchenko worte: > On Sat, 2016-06-04 at 09:16 -0400, George Spelvin wrote: > Which I against of. Please, use normal hex_to_bin() calls here. > > Compiler will inline it anyway, but at least will not do second check > for nothing. Um... huh? Neither hex_to_bin() nor hex2bin() are inline functions. They're declared as extern in and defined in lib/hexdump.c. One call is smaller than two calls, which is why I did that. It's also faster, as hex_to_bin() *is* inlined within hex2bin() (if you compile with -O). Is your request based on a false premise?