From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: Eric Nelson <eric@nelint.com>, Fabio Estevam <festevam@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision
Date: Mon, 6 Jun 2016 01:16:26 +0200 [thread overview]
Message-ID: <20160605231626.GA4076@archie.localdomain> (raw)
In-Reply-To: <20160604171525.GA29266@archie.localdomain>
Hi Eric, Fabio, Mark,
On Sat, Jun 04, 2016 at 07:15:25PM +0200, Clemens Gruber wrote:
> please don't merge the patch yet, I just observed a strange effect when
> resetting the board during playback / just after playback stops.
> At next boot time, sometimes the following error occurs:
> imx-sgtl5000 sound: ASoc: CODEC DAI sgtl5000 not registered
> imx-sgtl5000 sound: snd_soc_register_card failed (-517)
I looked into this today and discovered the following:
With my patch applied, if I reset the board just after playback, at the
next boot, the sgtl5000_fill_defaults function does not succeed: Writing
the default value 0x7060 to register 0x30 (CHIP_ANA_POWER) fails.
How did CHIP_ANA_POWER change with my patch: Before, only
LINREG_SIMPLE_POWERUP was cleared as is recommended in the datasheet
when using the internal LDO, now both LINREG_SIMPLE_POWERUP and
STARTUP_POWERUP are cleared, as is recommended when using external VDDD.
But why does the SGTL5000 nack that default write to CHIP_ANA_POWER
after a reboot, which interrupted the playback?
The following patch from Eric solved the problem; one write fails but it
continues setting the other registers and thus even if resetting a board
during playback, the sound still works after reboot:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-February/088356.html
Another workaround might be to not even write a default value to
CHIP_ANA_POWER, as in this patch from Eric:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-February/088355.html
What do you think we should do?
Regards,
Clemens
next prev parent reply other threads:[~2016-06-05 23:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 12:47 Clemens Gruber
2016-06-02 15:48 ` Fabio Estevam
2016-06-02 16:56 ` Mark Brown
2016-06-03 15:52 ` Clemens Gruber
2016-06-03 16:23 ` Eric Nelson
2016-06-04 5:18 ` Eric Nelson
2016-06-04 9:03 ` Clemens Gruber
[not found] ` <20160604171525.GA29266@archie.localdomain>
2016-06-05 23:16 ` Clemens Gruber [this message]
2016-06-06 1:22 ` [alsa-devel] " Fabio Estevam
2016-06-06 16:45 ` Clemens Gruber
2016-06-06 17:10 ` Fabio Estevam
2016-06-06 17:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160605231626.GA4076@archie.localdomain \
--to=clemens.gruber@pqgruber.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eric@nelint.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®