From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbcFFIry (ORCPT ); Mon, 6 Jun 2016 04:47:54 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36467 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbcFFIrv (ORCPT ); Mon, 6 Jun 2016 04:47:51 -0400 Date: Mon, 6 Jun 2016 09:47:47 +0100 From: Sudip Mukherjee To: Krzysztof Opasiak Cc: Valentina Manea , Shuah Khan , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: usbip: fix null pointer dereference Message-ID: <20160606084747.GB2324@sudip-tp> References: <1464873753-11456-1-git-send-email-sudipm.mukherjee@gmail.com> <57513FF3.6050608@samsung.com> <5754675B.1050104@gmail.com> <57553255.2050505@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57553255.2050505@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 10:20:37AM +0200, Krzysztof Opasiak wrote: > > > On 06/05/2016 07:54 PM, Sudip Mukherjee wrote: > > > > Yes, I should have seen earlier that the only caller has already > > dereferenced udc. So maybe the following will be appropriate in this > > situation. > > > > Your patch does exactly what Alan suggested and I agree with it;) yes, i saw those mails after i sent the reply with this proposed patch. > > Could you please resend this properly so Greg can easily pick it up? will send it tonight. regards sudip