From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbcFFIvD (ORCPT ); Mon, 6 Jun 2016 04:51:03 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34157 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbcFFIu6 (ORCPT ); Mon, 6 Jun 2016 04:50:58 -0400 Date: Mon, 6 Jun 2016 09:50:54 +0100 From: Sudip Mukherjee To: Leon Romanovsky Cc: Doug Ledford , Sean Hefty , Hal Rosenstock , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH] IB/core: remove dead code Message-ID: <20160606085054.GC2324@sudip-tp> References: <1465159552-11833-1-git-send-email-sudipm.mukherjee@gmail.com> <20160606072243.GR7477@leon.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160606072243.GR7477@leon.nu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 10:22:43AM +0300, Leon Romanovsky wrote: > On Sun, Jun 05, 2016 at 09:45:52PM +0100, Sudip Mukherjee wrote: > > prot_sg_cnt has been assigned with the value of ret which we have > > already checked to be non-zero so prot_sg_cnt can never be zero at this > > point of the code and hence the else part can never execute. > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/infiniband/core/rw.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > > index 1eb9b12..644589b 100644 > > --- a/drivers/infiniband/core/rw.c > > +++ b/drivers/infiniband/core/rw.c > > @@ -398,8 +398,6 @@ int rdma_rw_ctx_signature_init(struct rdma_rw_ctx *ctx, struct ib_qp *qp, > > else > > prev_wr->next = &ctx->sig->prot.reg_wr.wr; > > prev_wr = &ctx->sig->prot.reg_wr.wr; > > - } else { > > - ctx->sig->prot.mr = NULL; > > } > > You need to remove the "if (prot_sg_cnt) {" line too. There is no need > in it after you removed "else" case. ohhh, ofcourse. How silly of me.. :( will send v2 tonight. regards sudip