From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752099AbcFFNpS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 6 Jun 2016 09:45:18 -0400
Received: from mga04.intel.com ([192.55.52.120]:18655 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751764AbcFFNpP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 6 Jun 2016 09:45:15 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,427,1459839600"; 
   d="scan'208";a="991958954"
Date: Mon, 6 Jun 2016 16:45:09 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Pavel Machek <pavel@ucw.cz>, Guenter Roeck <linux@roeck-us.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Oliver Neukum <oneukum@suse.com>,
        Rajaram R <rajaram.officemail@gmail.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFC PATCHv2] usb: USB Type-C Connector Class
Message-ID: <20160606134509.GB11617@kuha.fi.intel.com>
References: <1463661894-22820-1-git-send-email-heikki.krogerus@linux.intel.com>
 <20160603202001.GB11253@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160603202001.GB11253@amd>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Fri, Jun 03, 2016 at 10:20:01PM +0200, Pavel Machek wrote:
> On Thu 2016-05-19 15:44:54, Heikki Krogerus wrote:
> > The purpose of this class is to provide unified interface for user
> > space to get the status and basic information about USB Type-C
> > Connectors in the system, control data role swapping, and when USB PD
> > is available, also power role swapping and Alternate Modes.
> > 
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > ---
> >  drivers/usb/Kconfig         |   2 +
> >  drivers/usb/Makefile        |   2 +
> >  drivers/usb/type-c/Kconfig  |   7 +
> >  drivers/usb/type-c/Makefile |   1 +
> >  drivers/usb/type-c/typec.c  | 957 ++++++++++++++++++++++++++++++++++++++++++++
> 
> For consistency, should this be either type-c/type-c.c or
> typec/typec.c?

For some reason I like to have the dash in the folder name, but I
don't like the idea that the port driver would be in form
type-c_something. I would prefer them to be named typec_something. Or
maybe just "something" and also name the typec.c maybe class.c or
core.c.

Is this a big problem? I guess we could just name the folder "typec".
Guenter, whats your opinion?


Thanks,

-- 
heikki