From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbcFFPIK (ORCPT ); Mon, 6 Jun 2016 11:08:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56694 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750789AbcFFPII (ORCPT ); Mon, 6 Jun 2016 11:08:08 -0400 Date: Mon, 6 Jun 2016 17:08:05 +0200 From: Alexandre Belloni To: Alexander Graf Cc: rtc-linux@googlegroups.com, leif.lindholm@linaro.org, linux-kernel@vger.kernel.org, Alessandro Zummo , Ard Biesheuvel Subject: Re: [PATCH] rtc: efi: Fail probing if RTC reads don't work Message-ID: <20160606150805.GB3363@piout.net> References: <1465119356-129799-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465119356-129799-1-git-send-email-agraf@suse.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 at 11:35:56 +0200, Alexander Graf wrote : > While the EFI spec mandates an RTC, not every implementation actually adheres > to that rule (or can adhere to it - some systems just don't have an RTC). > > For those, we really don't want to probe the EFI RTC driver at all, because if > we do we'd get a non-functional driver that does nothing useful but only spills > our kernel log with warnings. > > Signed-off-by: Alexander Graf > --- > drivers/rtc/rtc-efi.c | 6 ++++++ > 1 file changed, 6 insertions(+) Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com